Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ci] Remove dep on build_devtools from run_devtools_e2e_tests #30348

Closed
wants to merge 2 commits into from

Conversation

poteto
Copy link
Member

@poteto poteto commented Jul 16, 2024

Stack from ghstack (oldest at bottom):

The run_devtools_e2e_tests job does not appear to actually need anything
from the prior job since it always builds inline. Removing this dep
allows us to run both in parallel.

[ghstack-poisoned]
Copy link

vercel bot commented Jul 16, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-compiler-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 16, 2024 2:51pm

poteto added a commit that referenced this pull request Jul 16, 2024
The run_devtools_e2e_tests job does not appear to actually need anything
from the prior job since it always builds inline. Removing this dep
allows us to run both in parallel.

ghstack-source-id: 62e9eeb7ea7af0cbf94934669bf5510b28f460fe
Pull Request resolved: #30348
@facebook-github-bot facebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels Jul 16, 2024
[ghstack-poisoned]
poteto added a commit that referenced this pull request Jul 16, 2024
The run_devtools_e2e_tests job does not appear to actually need anything
from the prior job since it always builds inline. Removing this dep
allows us to run both in parallel.

ghstack-source-id: dd5c3f3d5c0cae14ff60564253b54bf5eb785fff
Pull Request resolved: #30348
@poteto poteto requested a review from hoxyq July 16, 2024 14:42
@react-sizebot
Copy link

react-sizebot commented Jul 16, 2024

Comparing: fee423e...eb1e148

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.js = 6.68 kB 6.68 kB +0.05% 1.82 kB 1.82 kB
oss-stable/react-dom/cjs/react-dom-client.production.js = 498.36 kB 498.36 kB = 89.37 kB 89.37 kB
oss-experimental/react-dom/cjs/react-dom.production.js = 6.69 kB 6.69 kB +0.05% 1.83 kB 1.83 kB
oss-experimental/react-dom/cjs/react-dom-client.production.js = 503.18 kB 503.18 kB = 90.08 kB 90.08 kB
facebook-www/ReactDOM-prod.classic.js = 598.11 kB 598.11 kB = 105.56 kB 105.56 kB
facebook-www/ReactDOM-prod.modern.js = 572.28 kB 572.28 kB = 101.46 kB 101.46 kB
test_utils/ReactAllWarnings.js Deleted 64.07 kB 0.00 kB Deleted 15.86 kB 0.00 kB

Significant size changes

Includes any change greater than 0.2%:

Expand to show
Name +/- Base Current +/- gzip Base gzip Current gzip
test_utils/ReactAllWarnings.js Deleted 64.07 kB 0.00 kB Deleted 15.86 kB 0.00 kB

Generated by 🚫 dangerJS against eb1e148

@poteto poteto closed this Jul 16, 2024
@poteto
Copy link
Member Author

poteto commented Jul 16, 2024

nvm, wrong assumption

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants